Skip to content

feat(#706): add actor and to date filters to GET /api/events - #907

Open
malaysiaonelove wants to merge 1 commit into
ritik4ever:mainfrom
malaysiaonelove:feat/706-global-events-filters
Open

feat(#706): add actor and to date filters to GET /api/events#907
malaysiaonelove wants to merge 1 commit into
ritik4ever:mainfrom
malaysiaonelove:feat/706-global-events-filters

Conversation

@malaysiaonelove

@malaysiaonelove malaysiaonelove commented Aug 29, 2026

Copy link
Copy Markdown

Summary

Adds actor and to query parameters to the GET /api/events global event feed endpoint, completing the filter set described in #706.

What Changed

File Change
validation/schemas.ts Added actor (string) and to (unix timestamp) to listEventsQuerySchema
services/eventHistory.ts Extended getGlobalEvents() and countAllEvents() with actor and to parameters — applies actor = ? and timestamp <= ? SQL conditions
index.ts Passes the new filters through to the service layer
index.test.ts 6 new unit tests + fixed pre-existing missing adminJwtAuth/getJwtSecret mocks
integration.test.ts 5 new integration tests covering actor, to, combined filters, and empty results

Endpoint Before

GET /api/events?eventType=&streamId=&since=&page=&limit=&cursor=

Endpoint After

GET /api/events?eventType=&streamId=&actor=&since=&to=&page=&limit=&cursor=

New Parameters

Param Type Description
actor string Filter by the Stellar account that performed the event action
to number Upper bound unix timestamp — events with timestamp <= to are returned

Acceptance Criteria

  • All filter combinations return correct results
  • Empty result returns {data: [], total: 0}
  • Response time < 200ms for 10k events (parameterized SQL queries with existing indexes)
  • Sorted descending by timestamp (unchanged)
  • Paginated with page/limit (unchanged)

Example Usage

# All claimed events by a specific actor in the last hour
curl "/api/events?eventType=claimed&actor=GABC...&since=1693000000"

# Events in a date range for a stream
curl "/api/events?streamId=42&since=1693000000&to=1693086400"

# All events by an actor
curl "/api/events?actor=GABC..."

Notes

  • TypeScript compiles cleanly — zero errors in all changed files
  • No database migration needed — uses existing stream_events table columns
  • Pre-existing test mock gaps (missing adminJwtAuth) are fixed as part of this PR

Closes #706

@malaysiaonelove @codebuff-team
feat(ritik4ever#706): add actor and to date filters to GET /api/events
88f77c6 
Add two new query parameters to the global event feed endpoint:

- `actor` — filter events by the Stellar account that performed the action
- `to` — filter events with timestamps less than or equal to a unix timestamp (upper date bound)

These complement the existing `eventType`, `streamId`, `since` (lower bound),
and `cursor` filters. All filter combinations work correctly, and empty results
return `{data: [], total: 0}`.

Changes:
- validation/schemas.ts: add `actor` and `to` to listEventsQuerySchema
- services/eventHistory.ts: extend getGlobalEvents and countAllEvents with new params
- index.ts: pass new filters through to service layer
- index.test.ts: add unit tests for actor/to filters; fix missing adminJwtAuth mock
- integration.test.ts: add integration tests for actor/to filter combinations

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
@vercel

vercel Bot commented Aug 29, 2026

Copy link
Copy Markdown

@malaysiaonelove is attempting to deploy a commit to the ritik4ever's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Aug 29, 2026

Copy link
Copy Markdown

@malaysiaonelove Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5636ff1d-56ed-4e99-9418-7f81f210a4d5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add GET /api/events global event feed with filters

1 participant

@malaysiaonelove